malikperangcic 3 Report post Posted November 24, 2012 Salam pada otai-otai Putera.com ni. Saya cuma ingin minta pandangan tuan/puan tentang coding form saya ni, adakah coding saya ni nampak berterabur@tak tersusun? atau ia mmg ok mcmni? saya masih baru lagi dlm web dev mgunakan php ni. harap ada yg boleh bagi pendapat. terima kasih.. ini code saya. [CODE] <?php $s_name = "booking form beta 1.0"; echo "<html> <head><title>$s_name</title> </head> <body>"; /*Array Area*/ $namaBulan = array(1=> "January", "February", "March", "April", "May", "June", "July", "August", "September", "October", "November", "December");$kereta['1'] = "Kelisa"; $kereta['2'] = "Viva"; /*End of Array Area*/ echo "<div align='center'> <h2>PLEASE FILL THE FORM TO ORDER</h2>\n $s_name </div> <hr color='red'>";$today = Time(); #dapatkan masa sekarang $bulansekarang = date("m" ,$today); #dapatkan bulan sekarang dgn menggunakan variable $today echo "<form action='processform.php' method='post'> <table width='50%'> <tr> <td align='right'> <b>Nama:<input type='text' name='pname' /><br /> <b>Alamat:<input type='text' name='paddress' /><br /> <b>No.IC<input type='text' name='pic' /><br />"; /*start bahagian tarikh dan list kereta*/ echo "<b>Tarikh Order:<select name='dateMO'>\n"; for ($n=1 ;$n<=12;$n++) { echo "<option value=$n"; if ($bulansekarang == $n) #tambah attribute today { echo " selected"; } echo "> $namaBulan[$n]\n"; #ambil array $namaBulan } echo "</select>"; $todayDay= date("d" , $today); echo "<select name='dateDay'>\n"; for ($n=1;$n<=31;$n++) { echo " <option value=$n"; if ($todayDay == $n ) { echo " selected"; } echo "> $n\n"; }echo "</select>"; $startYr = date("Y" , $today); echo "<select name='dateYr'>\n"; for ($n=$startYr;$n<=$startYr+3;$n++) { echo "<option value=$n"; if ($startYr == $n ) { echo " selected"; } echo"> $n\n"; } echo "</select><br />"; echo "<b>Tarikh Pulang:<select name='dateMO'>\n"; for ($n=1 ;$n<=12;$n++) { echo "<option value=$n"; if ($bulansekarang == $n) #tambah selected attribute { echo " selected"; } echo "> $namaBulan[$n]\n"; #ambil array $namaBulan } echo "</select>"; $todayDay= date("d" , $today); echo "<select name='dateDay'>\n"; for ($n=1;$n<=31;$n++) { echo " <option value=$n"; if ($todayDay == $n ) { echo " selected"; } echo "> $n\n"; } echo "</select>"; $startYr = date("Y" , $today); echo "<select name='dateYr'>\n"; for ($n=$startYr;$n<=$startYr+3;$n++) { echo "<option value=$n"; if ($startYr == $n ) { echo " selected"; } echo"> $n\n"; } echo "</select>\n</table></tr></td>"; echo "<table width='40%'> <tr><td align='right'> <b>Kereta:</b> <select name='kereta'> "; echo "<option value=''>Pilih Kereta</option>"; for ($i=1;$i<=2;$i++) { echo " <option value='$kereta'>$kereta[$i]</option>"; } echo "</table></tr></td> <table width='85%'> <tr><td align='center'>"; echo "\n<input type='submit' value='Hantar' />"; ?>[/CODE] Quote Share this post Link to post Share on other sites
malikperangcic 3 Report post Posted November 24, 2012 takde orang boleh tlg saya? Quote Share this post Link to post Share on other sites
Panglima Khalid 132 Report post Posted November 24, 2012 baru sehari...sabar ek... maybe org yg mampu jawab belum online, hujung minggu bizi bersama family... Quote Share this post Link to post Share on other sites
malikperangcic 3 Report post Posted November 25, 2012 terima kasih sedara...[quote name='Panglima Khalid' timestamp='1353800741' post='1087037'] baru sehari...sabar ek... maybe org yg mampu jawab belum online, hujung minggu bizi bersama family... [/quote] Quote Share this post Link to post Share on other sites
slier 28 Report post Posted November 25, 2012 (edited) Jawapan jujur? memang berterabur... Jangan bimbang, semua orang yang baru mula buat programming mmg coding macam ni 1.Jangan campur logic dengan presentation (Jangan campur php dengan html/css/js) 2.Jangan hasilkan html code menggunakan php (echo html code) 3.Letak kod php/html/css/js dalam fail masing2 Contoh: [CODE] //layout.php <html> <head> <title><?php echo $title; ?></title> <body> <?php echo $content; ?> </body> </html> [/CODE] [CODE] //content.php This is content //letak kod html disini [/CODE] [CODE] //index.php - contoh penggunaan file layout.php dan file content.php <?php $title ='test'; //letak logic php anda di sini $content = include 'content.php'; include 'layout.php'; ?> [/CODE] Ni cara paling simple nak asingkan logic dengan presentation tanpa menggunakan template library Jangan guna template mcm smarty..redundant.Php itu sendir mmg template language Kalau sudah mahir, boleh guna php framework Edited November 25, 2012 by slier Quote Share this post Link to post Share on other sites
mohdfadly 24 Report post Posted November 25, 2012 ya.. saya setuju dengan slier 100% Quote Share this post Link to post Share on other sites
malikperangcic 3 Report post Posted November 25, 2012 (edited) [quote name='slier' timestamp='1353853281' post='1087058'] Jawapan jujur? memang berterabur... Jangan bimbang, semua orang yang baru mula buat programming mmg coding macam ni 1.Jangan campur logic dengan presentation (Jangan campur php dengan html/css/js) 2.Jangan hasilkan html code menggunakan php (echo html code) 3.Letak kod php/html/css/js dalam fail masing2 Contoh: [CODE] //layout.php <html> <head> <title><?php echo $title; ?></title> <body> <?php echo $content; ?> </body> </html> [/CODE] [CODE] //content.php This is content //letak kod html disini [/CODE] [CODE] //index.php - contoh penggunaan file layout.php dan file content.php <?php $title ='test'; //letak logic php anda di sini $content = include 'content.php'; include 'layout.php'; ?> [/CODE] Ni cara paling simple nak asingkan logic dengan presentation tanpa menggunakan template library Jangan guna template mcm smarty..redundant.Php itu sendir mmg template language Kalau sudah mahir, boleh guna php framework [/quote] terima kasih tuan slier . ohh baru sy faham. . boleh tanya lg tak? kalau buat file html/css/java berasingan dgn file php boleh kan? Edited November 25, 2012 by malikperangcic Quote Share this post Link to post Share on other sites
slier 28 Report post Posted November 25, 2012 (edited) [quote name='malikperangcic' timestamp='1353865567' post='1087063'] terima kasih tuan slier . ohh baru sy faham. . boleh tanya lg tak? kalau buat file html/css/java berasingan dgn file php boleh kan? [/quote] ye boleh..best practise mmg anjurkan asingkan file..senang nak maintain html letak dalam php file (sebab klu letak dalam html file, php parser x akan parse file html) css letak dalam external css file javascript letak dalam external js file so bila ko edit mana2 file tu, bahagian yg x berkaitan x terjejas jika ko silap edit Edited November 25, 2012 by slier Quote Share this post Link to post Share on other sites
malikperangcic 3 Report post Posted November 25, 2012 [quote name='slier' timestamp='1353865998' post='1087064'] ye boleh..best practise mmg anjurkan asingkan file..senang nak maintain html letak dalam php file (sebab klu letak dalam html file, php parser x akan parse file html) css letak dalam external css file javascript letak dalam external js file so bila ko edit mana2 file tu, bahagian yg x berkaitan x terjejas jika ko silap edit [/quote] ok2..trime kasih byk2 ye tuan slier .saya cuba susun coding balik. Quote Share this post Link to post Share on other sites
